Skip to content

Conversation

runningcode
Copy link
Contributor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 5, 2021
@runningcode runningcode force-pushed the no/revved-up-by-ge branch 3 times, most recently from df6ff02 to 760d465 Compare January 5, 2021 16:31
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @runningcode! I've left some feedback inline.

README.adoc Outdated
@@ -2,6 +2,8 @@ image::https://badges.gitter.im/Join%20Chat.svg[Gitter,link=https://gitter.im/sp

image:https://github.com/spring-projects/spring-security/workflows/CI/badge.svg?branch=master["Build Status", link="https://github.com/spring-projects/spring-security/actions?query=workflow%3ACI"]

image:https://img.shields.io/badge/Revved%20up%20by-Gradle%20Enterprise-06A0CE?logo=Gradle&labelColor=02303A["Revved up by Gradle Enterprise", link="https://ge.spring.io/scans"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice for this link to be https://ge.spring.io/scans?search.rootProjectNames=spring-security instead so that it shows spring-security builds by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent Idea. Done!

@runningcode runningcode requested a review from jzheaux January 5, 2021 17:00
@jzheaux jzheaux self-assigned this Jan 5, 2021
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 5, 2021
@jzheaux jzheaux added this to the 5.5.0-M2 milestone Jan 5, 2021
@jzheaux jzheaux merged commit 6d59b10 into spring-projects:master Jan 5, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Jan 5, 2021

Thanks, @runningcode! This is now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants